Skip to content

Fix getattr to use __getattribute__ correctly #3748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 1, 2022
Merged

Fix getattr to use __getattribute__ correctly #3748

merged 2 commits into from
Jun 1, 2022

Conversation

youknowone
Copy link
Member

No description provided.

@youknowone youknowone force-pushed the getattr branch 2 times, most recently from b12a35a to c9c2487 Compare May 26, 2022 06:26
@youknowone youknowone changed the title Optimize getattr fast path Fix getattr May 26, 2022
@youknowone youknowone changed the title Fix getattr Fix getattr to use __getattribute__ correctly May 26, 2022
@youknowone youknowone merged commit 7182111 into RustPython:main Jun 1, 2022
@youknowone youknowone deleted the getattr branch June 1, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

@coolreader18 coolreader18 Awaiting requested review from coolreader18

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone