Skip to content

Implement Number protocol for PyComplex #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 10, 2022
Merged

Implement Number protocol for PyComplex #3838

merged 3 commits into from
Jul 10, 2022

Conversation

fanninpm
Copy link
Contributor

@fanninpm fanninpm commented Jul 3, 2022

Implementation based on #3507.

@fanninpm fanninpm requested review from youknowone and qingshi163 July 3, 2022 02:25
@fanninpm fanninpm force-pushed the complex-pynumber branch from 5b428ae to 508118e Compare July 3, 2022 02:25
@fanninpm fanninpm marked this pull request as ready for review July 3, 2022 19:31
@fanninpm fanninpm mentioned this pull request Jul 3, 2022
Open
qingshi163
qingshi163 requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@qingshi163 qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for the implement

@youknowone youknowone removed their request for review July 6, 2022 12:38
@Snowapril
Copy link
Contributor

I think Implementing missing PySequenceMethods, PyMappingMethods, PyNumberMethods for some types can be good first issue for first-comer. How do you think?

@youknowone youknowone requested a review from qingshi163 July 9, 2022 12:27
qingshi163
qingshi163 approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@qingshi163 qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@fanninpm fanninpm merged commit 11e9d81 into RustPython:main Jul 10, 2022
@hy-kiera hy-kiera mentioned this pull request Jul 14, 2022
Merged
@Karatuss Karatuss mentioned this pull request Jul 14, 2022
Closed
@fanninpm fanninpm deleted the complex-pynumber branch July 15, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

@qingshi163 qingshi163 qingshi163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fanninpm @Snowapril @youknowone @qingshi163