Skip to content

Fix is_unionable type_type check #3852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2022
Merged

Fix is_unionable type_type check #3852

merged 4 commits into from
Jul 9, 2022

Conversation

yonmilk
Copy link
Contributor

@yonmilk yonmilk commented Jul 9, 2022

type-type subclass identifying

type-type subclass identifying

Co-Authored-By: Hyunmin Shin <shm1193@gmail.com>
@Snowapril
Copy link
Contributor

test_or_type_operator_with_Protocol and test_or_type_operator_with_TypedDict in test_types.py are passed by your changes. Please add commit for removing comment and expectedFailure on them 😊

@youknowone youknowone merged commit 0c58d7b into RustPython:main Jul 9, 2022
@youknowone
Copy link
Member

thank you for contributing!

@yonmilk yonmilk deleted the union branch July 9, 2022 14:09
Karatuss added a commit to Karatuss/RustPython that referenced this pull request Jul 12, 2022
Co-Authored-By: Hyunmin Shin <shm1193@gmail.com>
Karatuss added a commit to Karatuss/RustPython that referenced this pull request Jul 12, 2022
Co-Authored-By: Hyunmin Shin <shm1193@gmail.com>
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants