Skip to content

Conversation

key262yek
Copy link
Contributor

Add attributes 'end_lineno' and 'end_offset' to SyntaxError

@key262yek key262yek closed this Jul 11, 2022
@key262yek key262yek deleted the update-traceback branch July 11, 2022 07:09
@key262yek key262yek restored the update-traceback branch July 11, 2022 07:15
@key262yek key262yek reopened this Jul 11, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Jul 13, 2022
@fanninpm
Copy link
Contributor

Is this superseded by #3870?

@youknowone
Copy link
Member

Oh, I think I merged the wrong one. Maybe he wanted to work for actual highlight feature in #3870 and just adding attributes here

@key262yek
Copy link
Contributor Author

I'm sorry, I should close this pr.
I tried to fix error which occurs while traceback update, and the first thing I did is add attribute to syntax error.
But, when I check it deeply, I realized the new attributes are related to highlight.
So I roll-back traceback update and change only about syntax error in #3870.

I didn't realize that the #3870 is merged.
Because highlight syntax update has barely done.

@key262yek key262yek closed this Jul 16, 2022
@key262yek key262yek deleted the update-traceback branch September 21, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants