Add weakproxy richcompare #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Jul 17, 2022
vm/src/builtins/weakproxy.rs
Outdated
| op: PyComparisonOp, | ||
| vm: &VirtualMachine, | ||
| ) -> PyResult<PyComparisonValue> { | ||
| println!("richcompare"); |
There was a problem hiding this comment.
Suggested change
| println!("richcompare"); |
vm/src/builtins/weakproxy.rs
Outdated
| vm: &VirtualMachine, | ||
| ) -> PyResult<PyComparisonValue> { | ||
| println!("richcompare"); | ||
| op.eq_only(|| { |
There was a problem hiding this comment.
Does weakproxy only support eq operation?
What happens if the proxy object is int and used for > operation?
There was a problem hiding this comment.
I checked cpython source code and it simply calls PyObject_RichCompare, which is PyObjectRef::rich_compare in RustPython.
youknowone
requested changes
Jul 17, 2022
vm/src/builtins/weakproxy.rs
Outdated
| vm: &VirtualMachine, | ||
| ) -> PyResult<PyComparisonValue> { | ||
| println!("richcompare"); | ||
| op.eq_only(|| { |
There was a problem hiding this comment.
I checked cpython source code and it simply calls PyObject_RichCompare, which is PyObjectRef::rich_compare in RustPython.
721cc74 to
a212d84
Compare
Co-Authored-By: Hyunmin Shin <shm1193@gmail.com>
a212d84 to
5c08546
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.