Skip to content

Update thread/threading/concurrent from CPython 3.10.5 #3921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 23, 2022
Merged

Update thread/threading/concurrent from CPython 3.10.5 #3921

merged 3 commits into from
Aug 23, 2022

Conversation

youknowone
Copy link
Member 

======================================================================
ERROR: test_interrupt_main_invalid_signal (test.test_threading.InterruptMainTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/user/Projects/RustPython/vm/pylib-crate/Lib/test/test_threading.py", line 1692, in test_interrupt_main_invalid_signal
    self.assertRaises(ValueError, _thread.interrupt_main, -1)
AttributeError: module '_thread' has no attribute 'interrupt_main'

@youknowone youknowone mentioned this pull request Jul 18, 2022
Closed
@fanninpm
Copy link
Contributor

Any update on this, now that #4082 has been merged?

@youknowone youknowone marked this pull request as ready for review August 22, 2022 20:06
fanninpm
fanninpm reviewed Aug 22, 2022
View reviewed changes
Lib/test/test_threading.py Outdated
Comment on lines 1667 to 1668
# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_interrupt_main_subthread(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this raise an error on your machine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is flaky.

@youknowone youknowone merged commit bd4b1a1 into RustPython:main Aug 23, 2022
@youknowone youknowone deleted the update-threading branch August 23, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @fanninpm