Skip to content

MutObjectSequenceOp find using Iteartor trait #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

MutObjectSequenceOp find using Iteartor trait #3940

wants to merge 1 commit into from

Conversation

youknowone
Copy link
Member

to isolate control flow code from next() operation

@youknowone youknowone requested a review from qingshi163 July 20, 2022 21:42
@youknowone youknowone force-pushed the refactor-MutObjectSequenceOp branch from 3fe2084 to f22d771 Compare July 23, 2022 06:32
qingshi163
qingshi163 approved these changes Jul 23, 2022
View reviewed changes
Copy link
Contributor

@qingshi163 qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great, I assume no effect of the performance?

@youknowone
Copy link
Member Author

I didn't test but rust is quite good at optimizing iterators.
Do you want performance check?

@qingshi163
Copy link
Contributor

I don't think any noticeable performance difference, but have a check is aways better :)

@youknowone youknowone mentioned this pull request Aug 7, 2022
Open
@youknowone youknowone force-pushed the refactor-MutObjectSequenceOp branch from f22d771 to e1035c4 Compare August 7, 2022 20:27
@youknowone
MutObjectSequenceOp find using Iteartor trait
d513aea 
to isolate control flow code from next() operation
@youknowone youknowone force-pushed the refactor-MutObjectSequenceOp branch from e1035c4 to d513aea Compare February 22, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingshi163 qingshi163 qingshi163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @qingshi163