Skip to content

Add or, ror andior to defaultdict #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Add or, ror andior to defaultdict #3947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c9e92c
Add `or`, `ror` and`ior` to `defaultdict`
jopemachine Jul 22, 2022
9c2a504
Reflect feedbacks
jopemachine Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Lib/collections/_defaultdict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,20 @@ def __reduce__(self):
args = ()
return type(self), args, None, None, iter(self.items())

def __or__(self, other):
if not isinstance(other, dict):
return NotImplemented

new = defaultdict(self.default_factory, self)
new.update(other)
return new

def __ror__(self, other):
if not isinstance(other, dict):
return NotImplemented

new = defaultdict(self.default_factory, other)
new.update(self)
return new

defaultdict.__module__ = 'collections'
2 changes: 0 additions & 2 deletions Lib/test/test_defaultdict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ def test_pickling(self):
o = pickle.loads(s)
self.assertEqual(d, o)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_union(self):
i = defaultdict(int, {1: 1, 2: 2})
s = defaultdict(str, {0: "zero", 1: "one"})
Expand Down