Skip to content

Refactor: sys.rs CI problem #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2022
Merged

Refactor: sys.rs CI problem #4049

merged 1 commit into from
Aug 13, 2022

Conversation

Karatuss
Copy link
Contributor

@Karatuss Karatuss commented Aug 12, 2022 •
edited
Loading

Remove stdlib::self in sys.rs and refactoring.

warning: unused import: `self`
[151](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:152)
  --> vm/src/stdlib/sys.rs:15:18
[152](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:153)
   |
[153](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:154)
15 |         stdlib::{self, builtins},
[154](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:155)
   |                  ^^^^
[155](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:156)
   |
[156](https://github.com/RustPython/RustPython/runs/7802998224?check_suite_focus=true#step:5:157)
   = note: `#[warn(unused_imports)]` on by default

@Karatuss Karatuss changed the title Refactor: sys.rs clippy problem Refactor: sys.rs CI problem Aug 12, 2022
@youknowone youknowone merged commit 2b2ed5a into RustPython:main Aug 13, 2022
@Karatuss Karatuss deleted the refactor/sys-clippy branch August 13, 2022 08:14
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Karatuss @youknowone