Skip to content

Update locale lib, tests and Add locale.getencoding #4155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Update locale lib, tests and Add locale.getencoding #4155

wants to merge 1 commit into from

Conversation

jopemachine
Copy link
Contributor

@jopemachine jopemachine commented Sep 9, 2022 •
edited
Loading

  • Update locale lib, tests
  • Add is_emscripten, is_wasi to Lib/test/support for support locale lib tests
  • Add locale.getencoding implemented in cpython 3.11

Related links

  • Python codes are copy-pasted from CPython.

@jopemachine jopemachine changed the title Update locale lib, tests, add locale.getencoding Update locale lib, tests, and Add locale.getencoding Sep 9, 2022
@jopemachine jopemachine changed the title Update locale lib, tests, and Add locale.getencoding Update locale lib, tests and Add locale.getencoding Sep 9, 2022
@jopemachine jopemachine changed the title Update locale lib, tests and Add locale.getencoding Update locale lib, tests and Add locale.getencoding Sep 9, 2022
@jopemachine jopemachine marked this pull request as draft September 12, 2022 02:43
@youknowone
Copy link
Member

Do you need update from #4081?

@jopemachine
Copy link
Contributor Author

jopemachine commented Sep 13, 2022 •
edited
Loading

I'm not sure about the PR but I think maybe not because this PR just update python built-in modules.

@jopemachine jopemachine force-pushed the update-locale branch 2 times, most recently from d2b0c9c to f5ef0ac Compare September 13, 2022 10:17
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Sep 16, 2022
@jopemachine
Copy link
Contributor Author

I'm waiting for this issue resolved before going further. #4157

@fanninpm fanninpm mentioned this pull request Feb 23, 2023
Merged
5 tasks
@fanninpm
Copy link
Contributor

@jopemachine Do you want to try again, now that #4530 has been merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jopemachine @youknowone @fanninpm