Skip to content

Fix compile error when using vm-tracing-logging is on #4195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

jopemachine
Copy link
Contributor

This PR fixes compile error when using vm-tracing-logging feature is on

Ref

@jopemachine
Copy link
Contributor Author

By the way, I think it would be good to set RUST_LOG environment variable to trace in RustPython when the vm-tracing-logging feature is on to avoid confusion.

I think some users like me could be a little embarrassed if any console log is not printed although the log feature is enabled.

@jopemachine jopemachine marked this pull request as ready for review October 4, 2022 03:02
@youknowone
Copy link
Member

@jopemachine that's a good idea.

@youknowone youknowone merged commit ec6461d into RustPython:main Oct 4, 2022
@youknowone youknowone added the z-ca-2022 Tag to track contrubution-academy 2022 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z-ca-2022 Tag to track contrubution-academy 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants