Skip to content

Fix repr for union #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2022
Merged

Fix repr for union #4253

merged 1 commit into from
Oct 29, 2022

Conversation

yonmilk
Copy link
Contributor

@yonmilk yonmilk commented Oct 28, 2022 •
edited
Loading

Fix repr function for union

@yonmilk yonmilk force-pushed the qualname_type branch 2 times, most recently from e08b971 to cc5f88f Compare October 28, 2022 18:24
@yonmilk yonmilk changed the title Fix qualname for type Fix repr for union Oct 28, 2022
DimitrisJim
DimitrisJim reviewed Oct 28, 2022
View reviewed changes
@yonmilk yonmilk closed this Oct 29, 2022
@yonmilk yonmilk reopened this Oct 29, 2022
@yonmilk yonmilk marked this pull request as ready for review October 29, 2022 08:00
DimitrisJim
DimitrisJim approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the fix!

@DimitrisJim DimitrisJim merged commit 77b821a into RustPython:main Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yonmilk @DimitrisJim