Skip to content

Add test in test_numbers #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

Add test in test_numbers #4285

merged 1 commit into from
Nov 21, 2022

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Nov 21, 2022

I added following test in test_numbers.

  • octal
  • exponent

DimitrisJim
DimitrisJim approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks. Failure seemed like a fluke unrelated to your change.

@DimitrisJim DimitrisJim merged commit f885db8 into RustPython:main Nov 21, 2022
@yt2b yt2b deleted the add_test branch November 21, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yt2b @DimitrisJim