Add Supporting for PyAtomicRef<Option<_>> and PyAtomicRef<PyObject> #4286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
approved these changes
Nov 22, 2022
vm/src/object/ext.rs
Outdated
| @@ -214,7 +214,10 @@ impl<T: PyPayload> ToPyObject for PyRefExact<T> { | |||
| } | |||
| } | |||
|
|
|||
| pub struct PyAtomicRef<T: PyObjectPayload>(PyAtomic<*mut Py<T>>); | |||
| pub struct PyAtomicRef<T> { | |||
| inner: PyAtomic<*mut i8>, | |||
There was a problem hiding this comment.
Suggested change
| inner: PyAtomic<*mut i8>, | |
| inner: PyAtomic<*mut u8>, |
it doesn't look important, but i've usually seen other code use u8 for this case. (to express void*)
vm/src/object/ext.rs
Outdated
Comment on lines
302
to
308
| let old = unsafe { self.swap(opt_ref) }; | ||
| if let Some(old) = old { | ||
| if let Some(frame) = vm.current_frame() { | ||
| frame.temporary_refs.lock().push(old.into()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
a tiny style suggestion
Suggested change
| let old = unsafe { self.swap(opt_ref) }; | |
| if let Some(old) = old { | |
| if let Some(frame) = vm.current_frame() { | |
| frame.temporary_refs.lock().push(old.into()); | |
| } | |
| } | |
| } | |
| let Some(old) = unsafe { self.swap(opt_ref) } else { | |
| return; | |
| }; | |
| if let Some(frame) = vm.current_frame() { | |
| frame.temporary_refs.lock().push(old.into()); | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.