Fix issues with flame-it. #4290

DimitrisJim · 2022-11-23T16:40:26Z

Running flame it works now as described in the profiling section:

echo "print('hello!')" >> script.py
cargo run --release --features flame-it script.py

or:

cargo run --release --features flame-it -- -c "print('hello world')"

to generate the flamescope (by default) which can be uploaded to speedscope.

DimitrisJim · 2022-11-23T16:54:53Z

src/lib.rs

+}
+
+#[cfg(feature = "flame-it")]
+fn write_profile(settings: &Settings) -> Result<(), Box<dyn std::error::Error>> {


Moved this further down, right above the tests so it doesn't obstruct the rest of the code.

DimitrisJim force-pushed the flame_it branch 2 times, most recently from 6087430 to ab50bed Compare November 23, 2022 16:54

DimitrisJim commented Nov 23, 2022

View reviewed changes

Fix issues with flame-it.

d075478

DimitrisJim force-pushed the flame_it branch from ab50bed to d075478 Compare November 23, 2022 16:57

fanninpm requested a review from youknowone November 23, 2022 16:59

youknowone approved these changes Nov 24, 2022

View reviewed changes

youknowone merged commit 3660ac2 into RustPython:main Nov 24, 2022

DimitrisJim deleted the flame_it branch November 24, 2022 11:23

Provide feedback