Skip to content

Use bitflags in Symbol #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 28, 2022
Merged

Use bitflags in Symbol #4298

merged 6 commits into from
Nov 28, 2022

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Nov 28, 2022

#4297
What I have done are as follows.

  • Adding bitflags in rustpython-codgen crate.
  • Replacing bool variable with bitflags in Symbol.

DimitrisJim
DimitrisJim reviewed Nov 28, 2022
View reviewed changes
@DimitrisJim DimitrisJim linked an issue Nov 28, 2022 that may be closed by this pull request
Use bitflags in Symbol #4297
Closed
DimitrisJim
DimitrisJim approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the find and PR!

@DimitrisJim DimitrisJim merged commit b9ed63e into RustPython:main Nov 28, 2022
@yt2b yt2b deleted the use_bitflags branch November 29, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use bitflags in Symbol
2 participants
@yt2b @DimitrisJim