-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix ExprKind::BoolOp
location
#4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should I add tests? diff --git a/compiler/parser/src/parser.rs b/compiler/parser/src/parser.rs
index d0f71fc80..f120dae70 100644
--- a/compiler/parser/src/parser.rs
+++ b/compiler/parser/src/parser.rs
@@ -218,4 +218,18 @@ class Foo(A, B):
let parse_ast = parse_expression(&source, "<test>").unwrap();
insta::assert_debug_snapshot!(parse_ast);
}
+
+ #[test]
+ fn test_parse_boolop_or() {
+ let source = String::from("x or y");
+ let parse_ast = parse_expression(&source, "<test>").unwrap();
+ insta::assert_debug_snapshot!(parse_ast);
+ }
+
+ #[test]
+ fn test_parse_boolop_and() {
+ let source = String::from("x and y");
+ let parse_ast = parse_expression(&source, "<test>").unwrap();
+ insta::assert_debug_snapshot!(parse_ast);
+ }
} Added. |
Thanks! |
@DimitrisJim Removed! |
@DimitrisJim Is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failure is unrelated. looks good to me, thanks again!
Rad, thanks @harupy! |
Fix #4305.