Skip to content

Refactor ExecutingFrame #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Dec 4, 2022

I added the following functions in ExecutingFrame.

  • jump_if
  • jump_if_or_pop

@yt2b
Copy link
Contributor Author

yt2b commented Dec 5, 2022

CI has failed in Run rust tests (ubuntu-latest).
I don't know why only this test has failed.

@fanninpm
Copy link
Contributor

fanninpm commented Dec 5, 2022

CI has failed in Run rust tests (ubuntu-latest).
I don't know why only this test has failed.

This is related to #4309. I recommend rebasing on a fresh copy of main.

@yt2b
Copy link
Contributor Author

yt2b commented Dec 5, 2022

@fanninpm
Thank you for the advice.
CI has passed!

Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the refactor!

@DimitrisJim DimitrisJim merged commit f70b8bf into RustPython:main Dec 6, 2022
@yt2b yt2b deleted the refactor_execute_instruction branch December 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants