Skip to content

Fix the end location of an implicitly-concatenated string #4324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 10, 2022
Merged

Fix the end location of an implicitly-concatenated string #4324

merged 4 commits into from
Dec 10, 2022

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Dec 10, 2022 •
edited
Loading

Before the fix:

"hello" "world"
      ^
      end_location

After the fix:

"hello" "world"
              ^
              end_location

@harupy harupy closed this Dec 10, 2022
@harupy harupy reopened this Dec 10, 2022
@DimitrisJim
Copy link
Member

another test passing: UNEXPECTED SUCCESS: test_continued_str (test.test_ast.EndPositionTests), just like the last time remove the deco from it and the failures should go.

@harupy
Copy link
Contributor Author

harupy commented Dec 10, 2022

@DimitrisJim Thanks for the comment! Removed the decorator.

DimitrisJim
DimitrisJim approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix @harupy

@DimitrisJim DimitrisJim merged commit 0723271 into RustPython:main Dec 10, 2022
@harupy harupy deleted the fix-end-location-of-concatenated-string branch December 10, 2022 12:43
@harupy harupy mentioned this pull request Dec 10, 2022
Merged
DimitrisJim added a commit that referenced this pull request Dec 10, 2022
@DimitrisJim
Merge pull request #4325 from harupy/4324-follow-up
2edd0d2 
A follow-up for #4324
@harupy harupy mentioned this pull request Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harupy @DimitrisJim