Skip to content

Use NotImplemented in binary operations #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2019
Merged

Use NotImplemented in binary operations #433

merged 3 commits into from
Feb 11, 2019

Conversation

OddCoincidence
Copy link
Contributor

@OddCoincidence OddCoincidence commented Feb 10, 2019 •
edited
Loading

Fixes #419.

  • Updated VirtualMachine::call_or_unsupported to fallback on a returned NotImplemented value, rather than catching NotImplementedError.
  • Updated objint and objfloat binary ops to return NotImplemented instead of raising NotImplementedError or raising ValueError directly.
  • Factored out ValueError construction from VirtualMachine::call_or_unsupported as the TODO suggested.
  • Use call_or_unsupported on eq/ne operations

@cthulahoops cthulahoops merged commit 45f45bf into RustPython:master Feb 11, 2019
@janczer janczer mentioned this pull request Feb 11, 2019
Merged
This was referenced Feb 12, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OddCoincidence @cthulahoops