Fix f-string padding #4361
Merged
Fix f-string padding #4361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Dec 26, 2022
vm/src/format.rs
Outdated
| @@ -535,8 +535,7 @@ impl FormatSpec { | |||
| ) -> Result<String, &'static str> { | |||
| let align = self.align.unwrap_or(default_align); | |||
|
|
|||
| // Use the byte length as the string length since we're in ascii | |||
| let num_chars = magnitude_string.len(); | |||
| let num_chars = magnitude_string.chars().count(); | |||
There was a problem hiding this comment.
ah, this is not the best. probably we'd better to pass StringKind here to not to count characters for ascii strings.
ea84f4b to
dd28a6b
Compare
|
I added a commit. I am thinking adding a struct including |
01aaa9b to
3ea6786
Compare
Co-Authored-By: yt2b <reinventing.the.wheels@gmail.com>
3ea6786 to
062a543
Compare
youknowone
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multibyte character exists in string, f-string padding doesn't work correctly.
For example:
f'{"🐍":4}'On CPython, The result of this code is below.
'🐍 'But on RustPython, The Result is different.
'🐍'I've fixed the character counting method.
With this fix, the following tests now pass.
test_non_ascii_identifierstest_unicode