Skip to content

Improved the fix for the continuing problem in the shell #4406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2023

Conversation

branai
Copy link
Contributor

@branai branai commented Jan 2, 2023

Improved my fix for #3892

@youknowone
Copy link
Member

could you please rebase the commits to remove the merge commit?

when https://github.com/RustPython/RustPython is upstream, git rebase -i upstream/main will work.

@branai
Copy link
Contributor Author

branai commented Jan 3, 2023

I added two small changes here to shell.rs, one fixes the issues with comments by checking the location of indentation errors, the other is for other errors.

@DimitrisJim I'd like to fix errors.rs, but I don't understand how to simplify it like you said. Any help you could give would be much appreciated. :)

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. please check the use statement part glitch.

src/shell.rs Outdated
@@ -9,6 +9,8 @@ use rustpython_vm::{
AsObject, PyResult, VirtualMachine,
};

use rustpython_parser::token::Tok;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be a part of line 3.

@youknowone youknowone merged commit 134355e into RustPython:main Jan 5, 2023
@youknowone
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants