Simplify string check in Lexer.lex_identifier
#4420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harupy
commented
Jan 4, 2023
Comment on lines
-248
to
-251
| let mut saw_b = false; | ||
| let mut saw_r = false; | ||
| let mut saw_u = false; | ||
| let mut saw_f = false; |
There was a problem hiding this comment.
I think the current logic is a bit difficult to verify if it's correct.
There was a problem hiding this comment.
oh definitely, the change makes it much better.
There was a problem hiding this comment.
I think this originally came from the tokenizer code.
DimitrisJim
reviewed
Jan 4, 2023
DimitrisJim
reviewed
Jan 4, 2023
DimitrisJim
reviewed
Jan 4, 2023
DimitrisJim
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies string check in
Lexer.lex_identifier.