Skip to content

Implement string format validation #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 5, 2023
Merged

Implement string format validation #4421

merged 3 commits into from
Jan 5, 2023

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Jan 5, 2023

String Format validation is not implemented.

>>>>> f'{"abc":,}'
'abc'

The output should be raised ValueError: Cannot specify ',' with 's'.
I've implemented format validation.

@yt2b yt2b marked this pull request as ready for review January 5, 2023 13:49
@yt2b yt2b force-pushed the implement_string_format_validation branch from 2632cae to e60a264 Compare January 5, 2023 15:40
@youknowone youknowone merged commit f1ca359 into RustPython:main Jan 5, 2023
@yt2b yt2b deleted the implement_string_format_validation branch January 5, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yt2b @youknowone