Skip to content

Fix integer format #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2023
Merged

Fix integer format #4427

merged 1 commit into from
Jan 7, 2023

Conversation

yt2b
Copy link
Contributor

@yt2b yt2b commented Jan 7, 2023

Panic occured when formatted from integer to multibyte characater.

>>>>> f"{0x1f5a5:c}"
thread 'main' panicked at 'assertion failed: s.is_ascii()', common/src/str.rs:75:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I've implemented the check whether string contains multibyte character.

@yt2b yt2b marked this pull request as ready for review January 7, 2023 03:58
youknowone
youknowone approved these changes Jan 7, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit 55aac85 into RustPython:main Jan 7, 2023
@yt2b yt2b deleted the fix_integer_format branch January 9, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yt2b @youknowone