Skip to content

Implement itertools.accumulate.__reduce__ and __setstate__ #4434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2023
Merged

Implement itertools.accumulate.__reduce__ and __setstate__ #4434

merged 2 commits into from
Jun 12, 2023

Conversation

lgyanf
Copy link
Contributor

@lgyanf lgyanf commented Jan 9, 2023

Add accumulate.reduce implementation for #3611.

Publishing as a draft to collect initial feedback. Behaviour seems to be identical to CPython's, but I'm still testing.

Relevant links

@fanninpm
Copy link
Contributor

fanninpm commented Jan 9, 2023

Is this related to #3611?

@youknowone youknowone mentioned this pull request Jan 10, 2023
Closed
27 tasks
@youknowone
Copy link
Member

Because you fixed related bug from the test suites, you can remove @unittest.expectedFailure decorator from test_accumulate_reducible test

@fanninpm
Copy link
Contributor

cc @Snowapril

@DimitrisJim DimitrisJim force-pushed the accumulate-reduce branch 2 times, most recently from 0de70f9 to e918d56 Compare May 19, 2023 15:32
@DimitrisJim DimitrisJim marked this pull request as ready for review May 19, 2023 19:44
@youknowone youknowone merged commit cbaed46 into RustPython:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lgyanf @fanninpm @youknowone @DimitrisJim