Skip to content

use qualname in TypeErrors for functions #4476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 1, 2023
Merged

use qualname in TypeErrors for functions #4476

merged 3 commits into from
Feb 1, 2023

Conversation

nicku12345
Copy link
Contributor

fix #4473

@DimitrisJim
Copy link
Member

It seems like clippy is complaining about a couple of things, if you could address those.

@fanninpm
Copy link
Contributor

It seems like clippy is complaining about a couple of things, if you could address those.

Those might be due to Rust 1.67.0 coming out on 26 Jan.

@DimitrisJim
Copy link
Member

ah, yeah, that's it @fanninpm. there's some format calls that need to be fixed.

youknowone
youknowone approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit 5fb03b6 into RustPython:main Feb 1, 2023
itsankitkp pushed a commit to itsankitkp/RustPython that referenced this pull request Feb 19, 2023
@nicku12345 @itsankitkp
use qualname in TypeErrors for functions (RustPython#4476)
3a08ff1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Qualname should be used in function's TypeErrors
4 participants
@nicku12345 @DimitrisJim @fanninpm @youknowone