-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Generate aliases for use by string parser. #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I can open another issue to keep track of the permanent fix for this (and for unicodedata), either pulling these aliases into a separate little crate or eventually adding them to |
afe0818
to
2b3bd79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this doing the same thing?
49adb5c
Co-authored-by: Jeong YunWon <69878+youknowone@users.noreply.github.com>
does that compile? that's basically what I was wanted to go with but there's some characters that need to be escaped or else |
Yes, that does compile and working well at least for BACKSPACE. |
Ah then push it through to here, I have no issue.
I still am not sure for this since they already have the data in UnicodeData.txt and they use their own implementation of |
wow, i didn't know their |
I tried to add alias, but I found unicode_names2 cannot regenerate master branch's output using the same version of generator 😂 |
Close in favor of #4582 |
We still need the tests from here, right? |
A temporary fix for #4566 so as to not hold back the parser. (This only covers the string parser for now, not
unicodedata
).