Skip to content

feat(argparse): update to 3.11 #4592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2023
Merged

feat(argparse): update to 3.11 #4592

merged 2 commits into from
Feb 28, 2023

Conversation

carlosmiei
Copy link
Contributor

Ran the tests and seemed ok

RUSTPYTHONPATH=Lib cargo run --release Lib/test/test_argparse.py 
    Updating git repository `https://github.com/youknowone/unicode_names2.git`
    Finished release [optimized] target(s) in 0.84s
     Running `target/release/rustpython Lib/test/test_argparse.py`
(...)
----------------------------------------------------------------------
Ran 1698 tests in 5.036s

OK

@fanninpm fanninpm mentioned this pull request Feb 28, 2023
Closed
fanninpm
fanninpm approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For future reference, I believe you can use the following command to test your changes locally (in a manner similar to RustPython's CI):

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

@youknowone
Copy link
Member

We'd better to add the commands to the issue.

@youknowone youknowone merged commit f251540 into RustPython:main Feb 28, 2023
@youknowone
Copy link
Member

Thank you!

@carlosmiei
Copy link
Contributor Author

LGTM.

For future reference, I believe you can use the following command to test your changes locally (in a manner similar to RustPython's CI):

# this runs all of the tests (not necessary if you know which test is affected)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v
# this runs only the test suite named "test_whatever" (usually located at `Lib/test/test_whatever.py`)
cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_whatever

For a list of all resources and more command-line options, you can execute cargo run --release --features ssl,jit -- -m test -h.

@fanninpm Thanks, I was not aware of that command 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosmiei @youknowone @fanninpm