Skip to content

Add unittset.expectedFailureIf for RustPython #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2023
Merged

Add unittset.expectedFailureIf for RustPython #4597

merged 2 commits into from
Mar 2, 2023

Conversation

youknowone
Copy link
Member

We really need conditional expectedFailure in the name of human right and pain killer.

@youknowone youknowone requested a review from fanninpm February 28, 2023 20:34
@youknowone youknowone force-pushed the expected-failure-if branch 3 times, most recently from dbd367e to 27592bc Compare March 1, 2023 09:06
@youknowone youknowone mentioned this pull request Mar 1, 2023
Merged
@youknowone youknowone force-pushed the expected-failure-if branch from 27592bc to 77ffa85 Compare March 1, 2023 13:31
@youknowone youknowone force-pushed the expected-failure-if branch from 77ffa85 to 367a948 Compare March 1, 2023 19:41
DimitrisJim
DimitrisJim approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a great helper to have

fanninpm
fanninpm approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@fanninpm fanninpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take care to remove these once all of their usages are gone.

@fanninpm fanninpm merged commit 6e4c2fe into RustPython:main Mar 2, 2023
@youknowone youknowone deleted the expected-failure-if branch March 2, 2023 19:23
@DimitrisJim DimitrisJim mentioned this pull request Apr 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@fanninpm fanninpm fanninpm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youknowone @DimitrisJim @fanninpm