Skip to content

baseline to start locale support for formatting :n #4609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

baseline to start locale support for formatting :n #4609

wants to merge 2 commits into from

Conversation

youknowone
Copy link
Member

was this ubuntu-only failure? i have no idea. but macos is fine.

@minhrongcon2000
Copy link
Contributor

In MacOS, the locale code is en_US.UTF-8 with a -

@youknowone
Copy link
Member Author

oh, yep. that was it! thank you!

@youknowone youknowone changed the title remove skip from test_types::test_int__format__locale baseline to start locale support for formatting :n Mar 2, 2023
@youknowone youknowone mentioned this pull request Mar 2, 2023
Open
@youknowone youknowone added the skip:ci Skip running the ci label Mar 2, 2023
@youknowone youknowone marked this pull request as draft March 2, 2023 13:49
@youknowone youknowone mentioned this pull request Apr 15, 2023
Merged
@youknowone youknowone mentioned this pull request Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip:ci Skip running the ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @minhrongcon2000