Skip to content

Implement Number Protocol for PyType, PySet and PyFrozenSet #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2023
Merged

Implement Number Protocol for PyType, PySet and PyFrozenSet #4619

merged 2 commits into from
Mar 2, 2023

Conversation

xiaozhiyan
Copy link
Contributor

Closes #4618

@xiaozhiyan xiaozhiyan changed the title Implement Number Protocol for PyType, PySet and PyFrozenSet Implement Number Protocol for PyType, PySet and PyFrozenSet Mar 2, 2023
@fanninpm fanninpm requested a review from qingshi163 March 2, 2023 18:23
@youknowone youknowone mentioned this pull request Mar 2, 2023
Open
qingshi163
qingshi163 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@qingshi163 qingshi163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youknowone youknowone merged commit 2d02933 into RustPython:main Mar 2, 2023
@xiaozhiyan xiaozhiyan deleted the implement-number-protocol-for-pytype-pyset-pyfrozenset branch March 2, 2023 19:43
@youknowone youknowone added the z-ls-2023 Tag to track Line OSS Sprint 2023 label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingshi163 qingshi163 qingshi163 approved these changes

Assignees
No one assigned
Labels
z-ls-2023 Tag to track Line OSS Sprint 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Number Protocol for PyType, PySet and PyFrozenSet
3 participants
@xiaozhiyan @qingshi163 @youknowone