Skip to content

Add BaseExceptionGroup #4681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 10, 2023
Merged

Add BaseExceptionGroup #4681

merged 3 commits into from
Mar 10, 2023
+17 −1

Conversation

abyesilyurt
Copy link
Contributor

Add BaseExceptionGroup that is introduced in Python 3.11. ExceptionGroup still needs to be implemented.

#4628

youknowone
youknowone requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's see how test goes without the line

@youknowone
Copy link
Member

youknowone commented Mar 10, 2023 •
edited
Loading

hmm. updating pickle/test_pickle by #4564 will be helpful. I don't think current patch has any problem.

@abyesilyurt
Copy link
Contributor Author

abyesilyurt commented Mar 10, 2023 •
edited
Loading

Updated test_pickle.py, but commented out ExceptionGroup, as it still needs to be implemented. I will leave it for the next PR.

fanninpm
fanninpm reviewed Mar 10, 2023
View reviewed changes
Lib/test/test_pickle.py Outdated
@@ -632,7 +632,9 @@ def test_exceptions(self):
ResourceWarning,
StopAsyncIteration,
RecursionError,
EncodingWarning):
EncodingWarning,
#ExceptionGroup,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#ExceptionGroup,
#ExceptionGroup, # TODO: RUSTPYTHON

This might be a good idea.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@fanninpm
Copy link
Contributor

The update test_pickle.py commit should mention the version of CPython you got the updates from.

@abyesilyurt abyesilyurt force-pushed the aziz/base_exc_group branch from fd2eb01 to aa508fa Compare March 10, 2023 14:33
@abyesilyurt
Copy link
Contributor Author

Thanks, added CPython version to the commit message.

@abyesilyurt abyesilyurt force-pushed the aziz/base_exc_group branch 2 times, most recently from 043ec50 to f083e1b Compare March 10, 2023 14:40
fanninpm
fanninpm reviewed Mar 10, 2023
View reviewed changes
@abyesilyurt abyesilyurt force-pushed the aziz/base_exc_group branch from f083e1b to 6cf99b4 Compare March 10, 2023 14:57
@abyesilyurt abyesilyurt requested a review from youknowone March 10, 2023 15:59
youknowone
youknowone approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you for contributing!

@youknowone youknowone merged commit 415cdb1 into RustPython:main Mar 10, 2023
@youknowone youknowone mentioned this pull request May 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abyesilyurt @youknowone @fanninpm