Skip to content

[Draft] Make builtin method type same as that of builtin function #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Draft] Make builtin method type same as that of builtin function #4686

wants to merge 2 commits into from

Conversation

seungha-kim
Copy link
Contributor

Fixes #3100

seungha-kim
seungha-kim commented Mar 13, 2023
View reviewed changes
@seungha-kim
Copy link
Contributor Author

seungha-kim commented Mar 13, 2023 •
edited
Loading

I missed that qualname of PyClassMethod must be considered too. (it is the cause of failing tests) Turning this PR to draft now and will look into PyClassMethod.

@seungha-kim seungha-kim marked this pull request as draft March 13, 2023 13:53
@seungha-kim seungha-kim changed the title Make builtin method type same as that of builtin function [Draft] Make builtin method type same as that of builtin function Mar 14, 2023
@seungha-kim seungha-kim force-pushed the builtin-method-type branch from 3a98980 to 6c3976f Compare March 14, 2023 10:14
@seungha-kim seungha-kim mentioned this pull request Mar 15, 2023
Open
@seungha-kim seungha-kim force-pushed the builtin-method-type branch from 16a0863 to ffece09 Compare March 23, 2023 15:03
@youknowone youknowone force-pushed the builtin-method-type branch from ffece09 to ea5e5ee Compare April 5, 2023 16:07
youknowone
youknowone reviewed Apr 5, 2023
View reviewed changes
vm/src/builtins/builtin_func.rs
zelf: None,
value: self,
module: None,
is_classmethod: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this field

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, i got it. we don't have PyMethodDef. So we cannot avoid it now.

@youknowone youknowone force-pushed the builtin-method-type branch 13 times, most recently from ca23718 to b76eb6d Compare April 9, 2023 13:56
@youknowone youknowone mentioned this pull request Apr 13, 2023
Merged
@youknowone youknowone force-pushed the builtin-method-type branch from b76eb6d to 2e06739 Compare April 24, 2023 19:42
@youknowone
Copy link
Member

I made #4873 including this patch.
It took almost a month 😵

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BuiltinFunctionType and BuiltinMethodType are different
3 participants
@seungha-kim @youknowone @blue-pandaa