-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix panic from test_int__format__locale #4711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
would you remove |
It will still fail because I didn't integrate locale into format integer with numeric option... But if you want to remove it to test whether it is panic, I will do it! |
you can replace |
4877e9c
to
89deabf
Compare
Lib/test/test_format.py
Outdated
@@ -493,6 +493,5 @@ def test_precision_c_limits(self): | |||
with self.assertRaises(ValueError) as cm: | |||
format(c, ".%sf" % (INT_MAX + 1)) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not intended change, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! This is not intended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also revert this line too
Lib/test/test_format.py
Outdated
@@ -493,6 +493,5 @@ def test_precision_c_limits(self): | |||
with self.assertRaises(ValueError) as cm: | |||
format(c, ".%sf" % (INT_MAX + 1)) | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also revert this line too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
223af5b
to
e153f7c
Compare
rerunning CI with #4593 |
Could you check the test result? new code seems generating malformatted string.
|
4e6ee3e
to
d39b44c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix #4588
closes #4593