Skip to content

memory optimization using leaked PyRef<PyStr> #4733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

memory optimization using leaked PyRef<PyStr> #4733

wants to merge 3 commits into from

Conversation

youknowone
Copy link
Member

@youknowone youknowone commented Mar 20, 2023 •
edited
Loading

in my environment, repl runtime consumes:

before: 6.6MB
after: 6.0MB

the difference is almost same as our doc db.

closes #4731
closes #4732
as included dependency

@youknowone youknowone force-pushed the static-str-opt branch 2 times, most recently from a7a8444 to 94b1f95 Compare March 20, 2023 16:33
@youknowone
Copy link
Member Author

i need to find a way to convince miri in safe way

@youknowone youknowone force-pushed the static-str-opt branch 2 times, most recently from fcb4fdb to feb751d Compare March 28, 2023 09:41
@youknowone
Copy link
Member Author

@qingshi163 could you review this PR?

@youknowone
Copy link
Member Author

uh, failing again. i will look in it.

@youknowone youknowone added C-enhancement New feature or request A-vm Area: virtual machine labels Mar 28, 2023
@youknowone youknowone mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingshi163 qingshi163 Awaiting requested review from qingshi163

@coolreader18 coolreader18 Awaiting requested review from coolreader18

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
A-vm Area: virtual machine C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone