Skip to content

descriptors and method calls to take &PyObject #4737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

descriptors and method calls to take &PyObject #4737

wants to merge 1 commit into from

Conversation

youknowone
Copy link
Member

No description provided.

youknowone
youknowone commented Mar 21, 2023
View reviewed changes
vm/src/builtins/function.rs
obj: Option<PyObjectRef>,
cls: Option<PyObjectRef>,
vm: &VirtualMachine,
) -> PyResult {
let (zelf, obj) = Self::_unwrap(zelf, obj, vm)?;
let obj = if vm.is_none(&obj) && !Self::_cls_is(&cls, obj.class()) {
zelf.into()
zelf.to_owned().into()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is a good idea or not..

@youknowone youknowone marked this pull request as draft March 21, 2023 19:21
@youknowone youknowone mentioned this pull request Mar 22, 2023
Merged
@youknowone
Copy link
Member Author

rebased as backup purpose

@youknowone youknowone closed this Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youknowone