update string_tests and solve failing test #4772
Merged
+71
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also check |
This comment was marked as resolved.
This comment was marked as resolved.
|
thank you for your review! I included test_unicode! |
youknowone
reviewed
Mar 26, 2023
|
Does |
a110c01 to
f7eb512
Compare
|
@fanninpm test_bytes is already updated by other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I update string_tests.py from python 3.11.2. And then I found that the test case in string_tests was failing because rustpython returns b'' when executing the statement b''.replace('', 'A', 100), whereas cpython returns b'A'.
After investigating, I discovered that there was no handling for cases where both the self and the first argument are empty strings, so I fixed it.