Skip to content

update test_ordered_dict.py from cpython 3.11.2 #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

update test_ordered_dict.py from cpython 3.11.2 #4775

wants to merge 1 commit into from

Conversation

sapsalian
Copy link
Contributor

update test_ordered_dict.py from cpython 3.11.2

fanninpm
fanninpm requested changes Mar 26, 2023
View reviewed changes
Lib/test/test_ordered_dict.py
Comment on lines +242 to +243
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break this out into a separate commit.

Lib/test/test_ordered_dict.py
Comment on lines +286 to +287
# TODO: RUSTPYTHON
@unittest.expectedFailure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please break this out into a separate commit.

@youknowone youknowone added A-stdlib z-ca-2023 Tag to track contrubution-academy 2023 labels Mar 26, 2023
@DimitrisJim
Copy link
Member

Thanks! The results have some failures and some successes. Failures:

test.test_ordered_dict.CSimpleLRUCacheTests.test_pop
test.test_ordered_dict.PySimpleLRUCacheTests.test_pop

and the unexpected successes:

test.test_ordered_dict.CPythonOrderedDictSubclassTests.test_copying
test.test_ordered_dict.CPythonOrderedDictSubclassTests.test_pop
test.test_ordered_dict.CPythonOrderedDictTests.test_copying
test.test_ordered_dict.CPythonOrderedDictTests.test_pop
test.test_ordered_dict.PurePythonOrderedDictSubclassTests.test_copying
test.test_ordered_dict.PurePythonOrderedDictSubclassTests.test_pop
test.test_ordered_dict.PurePythonOrderedDictTests.test_copying
test.test_ordered_dict.PurePythonOrderedDictTests.test_pop

@DimitrisJim
Copy link
Member

Superseded by #4846, thanks for opening the PR though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm requested changes

Assignees
No one assigned
Labels
A-stdlib z-ca-2023 Tag to track contrubution-academy 2023
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sapsalian @DimitrisJim @fanninpm @youknowone