Skip to content

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2023
Merged

Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib #4835

merged 4 commits into from
Apr 23, 2023

Conversation

Masorubka1
Copy link
Contributor

@Masorubka1 Masorubka1 commented Apr 4, 2023 •
edited
Loading

  1. split hashlib and _hashlib
  2. add libraries: _md5, _sha1, _sha3, _sha256, _blake2
  3. add tests for hashlib

@fanninpm
Copy link
Contributor

fanninpm commented Apr 4, 2023

Hmm… I think we need to split up stdlib/src/hashlib.rs into different modules and turn hashlib into a pure-Python module. What do you think, @youknowone?

@DimitrisJim DimitrisJim mentioned this pull request Apr 4, 2023
Closed
@youknowone
Copy link
Member

hashlib.py strongly supposes _hashlib is cpython-like openssl implementation. It will require efforts.
In my opinion, that's more like test-purpose compatibility rather than actual compatiblity. But I will happily take patch if anyone want to work on it.

@Masorubka1 Masorubka1 changed the title Update test_hashlib.py from Cpython v3.11.2 [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Apr 9, 2023
@Masorubka1 Masorubka1 changed the title [WIP] Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Update test_hashlib.py from Cpython v3.11.2 & refactor hashlib Apr 16, 2023
@Masorubka1
Copy link
Contributor Author

@youknowone Could you review this pr?

fanninpm
fanninpm reviewed Apr 18, 2023
View reviewed changes
@fanninpm fanninpm requested a review from youknowone April 18, 2023 15:41
youknowone
youknowone requested changes Apr 18, 2023
View reviewed changes
youknowone
youknowone reviewed Apr 18, 2023
View reviewed changes
youknowone
youknowone requested changes Apr 18, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, You made it 👍
Looks mostly good. I left a few comments.

fanninpm
fanninpm reviewed Apr 19, 2023
View reviewed changes
@Masorubka1 Masorubka1 requested a review from youknowone April 20, 2023 11:42
@youknowone youknowone mentioned this pull request Apr 21, 2023
Merged
youknowone
youknowone requested changes Apr 21, 2023
View reviewed changes
@youknowone youknowone force-pushed the test_hashlib.py branch 2 times, most recently from 40d9194 to 7ea4fc6 Compare April 23, 2023 06:27
youknowone
youknowone approved these changes Apr 23, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is great, I like it very much!

@youknowone youknowone merged commit 4e0890a into RustPython:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Masorubka1 @fanninpm @youknowone