Skip to content

Merge define_exception into pyexception #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Merge define_exception into pyexception #4886

merged 1 commit into from
Apr 24, 2023
+603 −618

Conversation

youknowone
Copy link
Member

@sobolevn would you review this PR?

@youknowone youknowone requested a review from DimitrisJim April 18, 2023 06:28
@youknowone youknowone force-pushed the pyexception branch 2 times, most recently from fbd3d13 to 154d483 Compare April 18, 2023 06:52
sobolevn
sobolevn approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much nicer! Thank you! 👍

@youknowone youknowone mentioned this pull request Apr 21, 2023
Merged
@youknowone youknowone merged commit 776bda6 into RustPython:main Apr 24, 2023
@youknowone youknowone deleted the pyexception branch April 24, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowone @sobolevn