Add test_poll.py from Cpython v3.11.2 #4888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanninpm
reviewed
Apr 18, 2023
Lib/test/test_poll.py
Outdated
| self.assertRaises(OverflowError, pollster.poll, INT_MAX + 1) | ||
| self.assertRaises(OverflowError, pollster.poll, UINT_MAX + 1) | ||
|
|
||
| @unittest.skip("TODO: RUSTPYTHON") |
There was a problem hiding this comment.
Suggested change
| @unittest.skip("TODO: RUSTPYTHON") | |
| @unittest.skip("TODO: RUSTPYTHON, I forget why we're skipping this. @Masorubka1 do you know why?") |
There was a problem hiding this comment.
because rustpython fails filedescriptor reallocation
# trigger ufds array reallocation
for fd in rfds:
pollster.unregister(fd)There was a problem hiding this comment.
Suggested change
| @unittest.skip("TODO: RUSTPYTHON") | |
| @unittest.skip("TODO: RUSTPYTHON, fd reallocation") |
There was a problem hiding this comment.
@fanninpm adding reason will be nice, but I don't want to make them as burden for contributors
|
@fanninpm well, there is flap test(as i understand)[or some invalid pointers]. |
9b8ba21 to
fddbf07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.