Rename method/member types #4927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @moreal |
fanninpm
reviewed
Apr 24, 2023
| @@ -5,7 +5,7 @@ use super::{ | |||
| use crate::{ | |||
| builtins::{ | |||
| descriptor::{ | |||
| DescrObject, MemberDef, MemberDescrObject, MemberGetter, MemberKind, MemberSetter, | |||
| DescrObject, MemberGetter, MemberKind, MemberSetter, PyMemberDef, PyMemberDescriptor, | |||
There was a problem hiding this comment.
Would it make sense to also have PyMemberGetter, PyMemberKind, and PyMemberSetter?
There was a problem hiding this comment.
Though I am not confident of this logic,
Those types are RustPython's internal while PyMemberDef is a part of public python C-API starting with PyMember_
We don't use Py prefix for our internal but use it for exposed Python types. But not sure about the exact boundary yet.
DimitrisJim
approved these changes
Apr 25, 2023
|
Maybe we'd better to study more on how pyo3 names them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyMethodDef.PyMehtodDefis a python object in CPython