Port configurable repr quote from Ruff and refactoring #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Charlie Marsh <charlie.r.marsh@gmail.com>
6251537 to
d21066d
Compare
youknowone
commented
May 3, 2023
|
|
||
| let quote = if dquoted { '"' } else { '\'' }; | ||
| // if we don't need to escape anything we can just copy | ||
| let unchanged = out_len == in_len; |
There was a problem hiding this comment.
Due to line 406, this test seems always failing. It must have been always using slow path
Comment on lines
+109
to
+115
| pub fn with_forced_quote(source: &'a str, quote: Quote) -> Self { | ||
| let layout = EscapeLayout { quote, len: None }; | ||
| Self { source, layout } | ||
| } |
There was a problem hiding this comment.
Python requires length calculation due to allocating string object, but formatters doesn't.
will this be helpful for formatter?
let escape = if source.len() < TOO_LONG_TO_FORMAT {
UnicodeEscape::output_layout(source, Quote::Double)
} else {
UnicodeEscape::with_forced_quote(source, Quote::Double)
};73f2689 to
c8ee020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic was ported, but kept the default
reprbehaviors to use single quote.I think the term
repr- not representation or debug - meansrepr()in Python.Instead of it, I added other configurable methods for each str and bytes.
Rather than the name repr, I found
unicode_escapecodec is doing the same thing.I will try to organize them more under 'escape' later.
I realized str and bytes are doing almost same thing but have so much different interface.
Unrelated note: I am thinking the new crate name for these stuffs
rustpython-literalincluding str/bytes/float repr