Skip to content

Break continue fix #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2019
Merged

Conversation

chwoda1
Copy link
Contributor

@chwoda1 chwoda1 commented Feb 19, 2019

Description is deprecated so I simply removed them because it was interfering with error handling. The rest of the changes pertain to issue #497

chwoda1 and others added 3 commits February 19, 2019 02:18
…nside of a loop or not. This is useful to determine whether or not we can use looping specific keywords such as break or continue.
…nside of a loop or not. This is useful to determine whether or not we can use looping specific keywords such as break or continue.
@OddCoincidence
Copy link
Contributor

Thanks for the PR! With this change, I can still create an invalid break statement in some cases, e.g.:

def foo():
    for x in range(10):
        def inner():
            break

Could your fix cover these as well?

@codecov-io
Copy link

Codecov Report

Merging #500 into master will decrease coverage by 1.4%.
The diff coverage is 15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
- Coverage   56.98%   55.58%   -1.41%     
==========================================
  Files          67       67              
  Lines       12378    12620     +242     
  Branches     2937     3056     +119     
==========================================
- Hits         7054     7015      -39     
- Misses       3536     3814     +278     
- Partials     1788     1791       +3
Impacted Files Coverage Δ
vm/src/builtins.rs 56.54% <0%> (ø) ⬆️
src/main.rs 24.56% <0%> (ø) ⬆️
vm/src/error.rs 0% <0%> (ø) ⬆️
vm/src/compile.rs 46.56% <21.42%> (-15.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8c1ef...9092d1f. Read the comment docs.

@chwoda1
Copy link
Contributor Author

chwoda1 commented Feb 20, 2019

Thanks for the code review! Looks like the issues you brought up are fixed. Let me know if you need me to change anything else

@windelbouwman windelbouwman merged commit b7dfbeb into RustPython:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants