Break continue fix #500
Merged
Break continue fix #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nside of a loop or not. This is useful to determine whether or not we can use looping specific keywords such as break or continue.
…nside of a loop or not. This is useful to determine whether or not we can use looping specific keywords such as break or continue.
|
Thanks for the PR! With this change, I can still create an invalid def foo():
for x in range(10):
def inner():
breakCould your fix cover these as well? |
Merge branch 'master' of https://github.com/RustPython/RustPython into break-continue-fix
…ython into break-continue-fix
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
- Coverage 56.98% 55.58% -1.41%
==========================================
Files 67 67
Lines 12378 12620 +242
Branches 2937 3056 +119
==========================================
- Hits 7054 7015 -39
- Misses 3536 3814 +278
- Partials 1788 1791 +3
Continue to review full report at Codecov.
|
|
Thanks for the code review! Looks like the issues you brought up are fixed. Let me know if you need me to change anything else |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description is deprecated so I simply removed them because it was interfering with error handling. The rest of the changes pertain to issue #497