Implemented compare operation for boolean types in JIT engine #5081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
reviewed
Oct 6, 2023
jit/src/instructions.rs
Outdated
| @@ -348,6 +348,22 @@ impl<'a, 'b> FunctionCompiler<'a, 'b> { | |||
| .push(JitValue::Bool(self.builder.ins().bint(types::I8, val))); | |||
| Ok(()) | |||
| } | |||
| (JitValue::Bool(a), JitValue::Bool(b)) => { | |||
There was a problem hiding this comment.
python bool is a subclass of int and they can be mixed in operations. This pattern looks like matching only for (bool, bool) operands. Isn't this better to be combined to (int, int) case? Then it will allows also (bool, int) or (int, bool) operations.
There was a problem hiding this comment.
Yeah! Makes sense , will update it. Thanks for response !
|
This is done, Now both int and bool types can be compared. |
|
oh, could you run |
|
Sure |
|
Hi , This is rebased with current main branch. |
a9ac6b2 to
eb83b72
Compare
|
you may have forgot fetching upstream. rebased again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JIT, Implemented more comparison operations for boolean types, and added tests