Skip to content

[JIT] Binary operations for integers and floating-point numbers allowing mixed type calculations #5086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2023
Merged

[JIT] Binary operations for integers and floating-point numbers allowing mixed type calculations #5086

merged 2 commits into from
Oct 7, 2023

Conversation

MannarAmuthan
Copy link
Contributor

Implemented Binary operations (ADD, SUB, MUL, DIV for now) for allowing mixed type calculations with integers and floating point numbers

  1. I assume that division by zero is yet to be handled in current JIT implementation.
  2. Added necessary tests

youknowone
youknowone approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@youknowone youknowone merged commit f1b3623 into RustPython:main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MannarAmuthan @youknowone