Skip to content

implement PyObject_Type and PyObject_TypeCheck #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2023
Merged

implement PyObject_Type and PyObject_TypeCheck #5091

merged 2 commits into from
Oct 17, 2023

Conversation

dannasman
Copy link
Contributor

Hi!

Here are proposed implementations for PyObject_Type and PyObject_TypeCheck related to issue (#3244 ).

@fanninpm fanninpm mentioned this pull request Oct 16, 2023
Open
youknowone
youknowone approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I felt like obj.type() already is PyObject_Type. Maybe not due to return type.

Thank you!

@youknowone youknowone merged commit 0e72ba8 into RustPython:main Oct 17, 2023
This was referenced Oct 18, 2023
Draft
Merged
@dannasman dannasman deleted the add_PyObject_Type_PyObject_TypeCheck branch October 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannasman @youknowone