Skip to content

fix type_check #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix type_check #5097

merged 1 commit into from
Oct 20, 2023

Conversation

dannasman
Copy link
Contributor

@dannasman dannasman commented Oct 19, 2023 •
edited
Loading

Hi!

I noticed that there was an error in my earlier pull request (#5091 ). fast_isinstance() should be called by self instead of self.class() in type_check. Sorry for the inconvenience.

youknowone
youknowone approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youknowone youknowone merged commit 0357661 into RustPython:main Oct 20, 2023
@dannasman dannasman deleted the type_check_fix branch October 20, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowone youknowone youknowone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dannasman @youknowone