None.__ne__(None) should be NotImplemented #5124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b667ee to
ad59192
Compare
youknowone
reviewed
Nov 28, 2023
fe2ae32 to
6b4e7c4
Compare
This comment was marked as spam.
This comment was marked as spam.
2be96c1 to
5c7d042
Compare
|
@youknowone this is ready now, but I'm not sure why tests failed on wasm-wasi. |
5c7d042 to
d5cbf76
Compare
youknowone
approved these changes
Dec 20, 2023
|
Done - thanks @youknowone! |
|
Could you also check clippy errors? To check it, see the 'Details' of ubuntu-latest build. I am really sorry for late response during you are writing this patch. And thank you so much for contributing. |
1ead4c5 to
63026c3
Compare
|
Weird, now it's failing on a manual hash implementation? I've rebased against |
|
That's due to recent Rust version upgrade. I fixed it on main branch. rebasing on main again will fix it. |
Co-authored-by: Jeong, YunWon <69878+youknowone@users.noreply.github.com>
63026c3 to
0ac64e1
Compare
|
Sorry, must've missed your comment - rebased |
youknowone
approved these changes
Jan 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed in Python 3.12. Closes #5103